pi-mcp

All four hints declared on every tool

7/7 tools missing one or more hints — bash (missing: readOnlyHint, idempotentHint); edit (missing: readOnlyHint, idempotentHint); find (missing: destructiveHint, idempotentHint), +4 more. OpenAI's directory rejects tools where any of the four hints are missing or non-boolean.

For every tool, set all four hints (readOnlyHint, destructiveHint, idempotentHint, openWorldHint) to explicit true/false values that match the handler’s actual behaviour.

Tool annotations match behaviour

2 read-only tools perform write/delete/exec — find (line 62: spawn(options.fdPath, args, { stdio: ["ignore", "pipe", "pipe"] })); grep (line 69: spawn(options.rgPath, args, { stdio: ["ignore", "pipe", "pipe"] }))

Either remove the readOnlyHint:true annotation, or remove the write/delete call from the tool handler.

Descriptions match behaviour

1 tool describes read intent but its handler mutates — find (line 62: spawn(options.fdPath, args, { stdio: ["ignore", "pipe", "pipe"] }))

Rename the tool, rewrite the description, or move the side-effect into a separate clearly-named tool.

Tool inputs are validated

Only 0/7 tool handlers declare input schemas (0%)

Declare an inputSchema with zod/joi/yup on every tool definition.

Tests exist

No test files found

Add tests that exercise each declared tool.

Shell command execution

3 child_process/subprocess calls in production code — runs shell commands (src/vendor/shell.ts:22, src/vendor/shell.ts:40, src/vendor/shell.ts:136)

Prefer library functions over shell-outs. If you must shell out, ensure all inputs are properly escaped.