cnc-fluidnc-mcp

Tool annotations

No tools have read-only/destructive annotations

Add readOnlyHint or destructiveHint annotations to every tool so hosts can warn users before invoking.

All four hints declared on every tool

27/27 tools missing one or more hints — backup_config (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); list_backups (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); restore_config (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint), +24 more. OpenAI's directory rejects tools where any of the four hints are missing or non-boolean.

For every tool, set all four hints (readOnlyHint, destructiveHint, idempotentHint, openWorldHint) to explicit true/false values that match the handler’s actual behaviour.

Destructive tools are labelled

1 tool perform destructive updates without destructiveHint — delete_macro deletes at line 208 (unlink(path))

Add destructiveHint:true to any tool whose handler calls .delete(), .upsert(), .update(), unlink, rm, DELETE, DROP, REPLACE INTO, or any operation that overwrites existing data.

Descriptions match behaviour

3 tools describe read intent but their handlers mutate — list_backups (line 12: mkdir(dir, { recursive: true })); list_macros (line 11: mkdir(dir, { recursive: true })); get_macro (line 11: mkdir(dir, { recursive: true }))

Rename the tool, rewrite the description, or move the side-effect into a separate clearly-named tool.

Tool inputs are validated

19/27 tool handlers declare input schemas (70%)

Declare an inputSchema with zod/joi/yup on every tool definition.

Tool handlers catch errors

Only 8/27 tool handlers wrap calls in try/catch (30%)

Wrap each tool handler body in try/catch and return a structured error response.

Tests exist

No test files found

Add tests that exercise each declared tool.

Production dependencies are patched

0 critical, 1 high severity in production deps — ws@8.20.0 (high), ws@8.20.0 (low)

Run npm audit fix, or upgrade the affected packages to a non-vulnerable version.

Tool description accuracy

3 tools have description/behavior mismatches: list_backups: description implies read-only but handler writes/deletes/executes; list_macros: description implies read-only but handler writes/deletes/executes; get_macro: description implies read-only but handler writes/deletes/executes

Update tool descriptions to accurately reflect all capabilities — especially write, delete, or execute operations.