eda-agent

Tool annotations

No tools have read-only/destructive annotations

Add readOnlyHint or destructiveHint annotations to every tool so hosts can warn users before invoking.

All four hints declared on every tool

296/296 tools missing one or more hints — pcb_get_components (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); tool_catalog (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); tool_invoke (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint), +293 more. OpenAI's directory rejects tools where any of the four hints are missing or non-boolean.

For every tool, set all four hints (readOnlyHint, destructiveHint, idempotentHint, openWorldHint) to explicit true/false values that match the handler’s actual behaviour.

Destructive tools are labelled

3 tools perform destructive updates without destructiveHint — app_set_intent deletes at line 726 (path.unlink()); kicad_get_fab_stats deletes at line 506 (os.remove(out)); kicad_run_spice deletes at line 1077 (os.remove(cir))

Add destructiveHint:true to any tool whose handler calls .delete(), .upsert(), .update(), unlink, rm, DELETE, DROP, REPLACE INTO, or any operation that overwrites existing data.

Descriptions match behaviour

1 tool describes read intent but its handler mutates — design_snapshot_inventory (line 395: cache_path.write_text()

Rename the tool, rewrite the description, or move the side-effect into a separate clearly-named tool.

Tool inputs are validated

210/296 tool handlers declare input schemas (71%)

Declare an inputSchema with zod/joi/yup on every tool definition.

Tool handlers catch errors

Only 68/296 tool handlers wrap calls in try/catch (23%)

Wrap each tool handler body in try/catch and return a structured error response.

Tests exist

No test files found

Add tests that exercise each declared tool.

Shell command execution

1 child_process call — runs shell commands

Prefer library functions over shell-outs. If you must shell out, ensure all inputs are properly escaped.

Tool description accuracy

design_snapshot_inventory: description implies read-only but handler writes/deletes/executes

Update tool descriptions to accurately reflect all capabilities — especially write, delete, or execute operations.