kali-mcp

Tool annotations

8/101 tools have annotations

Add readOnlyHint or destructiveHint annotations to every tool so hosts can warn users before invoking.

All four hints declared on every tool

101/101 tools missing one or more hints — get_job_status (missing: destructiveHint, idempotentHint, openWorldHint); get_job_output (missing: destructiveHint, idempotentHint, openWorldHint); list_jobs (missing: destructiveHint, idempotentHint, openWorldHint), +98 more. OpenAI's directory rejects tools where any of the four hints are missing or non-boolean.

For every tool, set all four hints (readOnlyHint, destructiveHint, idempotentHint, openWorldHint) to explicit true/false values that match the handler’s actual behaviour.

Destructive tools are labelled

6 tools perform destructive updates without destructiveHint — msf_search deletes at line 44 (os.unlink(rc_file)); msf_run_module deletes at line 97 (os.unlink(rc_file)); nmap_xml_scan deletes at line 231 (os.unlink(xml_path))

Add destructiveHint:true to any tool whose handler calls .delete(), .upsert(), .update(), unlink, rm, DELETE, DROP, REPLACE INTO, or any operation that overwrites existing data.

Descriptions match behaviour

2 tools describe read intent but their handlers mutate — msf_search (line 39: with open(rc_file, "w") as f:); screenshot_urls (line 93: os.unlink(url_file))

Rename the tool, rewrite the description, or move the side-effect into a separate clearly-named tool.

Tool inputs are validated

90/101 tool handlers declare input schemas (89%)

Declare an inputSchema with zod/joi/yup on every tool definition.

Tool handlers catch errors

Only 21/101 tool handlers wrap calls in try/catch (21%)

Wrap each tool handler body in try/catch and return a structured error response.

Tests exist

No test files found

Add tests that exercise each declared tool.

Shell command execution

1 child_process call — runs shell commands

Prefer library functions over shell-outs. If you must shell out, ensure all inputs are properly escaped.

Tool description accuracy

msf_search: description implies read-only but handler writes/deletes/executes; screenshot_urls: description implies read-only but handler writes/deletes/executes

Update tool descriptions to accurately reflect all capabilities — especially write, delete, or execute operations.