mcp-ssh-manager

Tool annotations

No tools have read-only/destructive annotations

Add readOnlyHint or destructiveHint annotations to every tool so hosts can warn users before invoking.

All four hints declared on every tool

37/37 tools missing one or more hints — ssh_execute (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); ssh_upload (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); ssh_download (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint), +34 more. OpenAI's directory rejects tools where any of the four hints are missing or non-boolean.

For every tool, set all four hints (readOnlyHint, destructiveHint, idempotentHint, openWorldHint) to explicit true/false values that match the handler’s actual behaviour.

Descriptions match behaviour

6 tools describe read intent but their handlers mutate — ssh_execute (line 466: spawn(cmd, {); ssh_download (line 466: spawn(cmd, {); ssh_connection_status (line 466: spawn(cmd, {)

Rename the tool, rewrite the description, or move the side-effect into a separate clearly-named tool.

Tool inputs are validated

36/37 tool handlers declare input schemas (97%)

Declare an inputSchema with zod/joi/yup on every tool definition.

Tool handlers catch errors

36/37 tool handlers wrap calls in try/catch (97%)

Wrap each tool handler body in try/catch and return a structured error response.

Tests exist

No test files found

Add tests that exercise each declared tool.

Shell command execution

4 child_process calls — runs shell commands

Prefer library functions over shell-outs. If you must shell out, ensure all inputs are properly escaped.

Dependency freshness

1/5 production deps stale: @iarna/toml@2023-07-15 (3.1y)

Tool description accuracy

7 tools have description/behavior mismatches: ssh_execute: description implies read-only but handler writes/deletes/executes; ssh_download: description implies read-only but handler writes/deletes/executes; ssh_monitor: description implies read-only but handler writes/deletes/executes

Update tool descriptions to accurately reflect all capabilities — especially write, delete, or execute operations.