Obsidian

Tool annotations

No tools have read-only/destructive annotations

Add readOnlyHint or destructiveHint annotations to every tool so hosts can warn users before invoking.

All four hints declared on every tool

28/28 tools missing one or more hints — obsidian_block_reference (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); obsidian_graph_analysis (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); obsidian_periodic_notes (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint), +25 more. OpenAI's directory rejects tools where any of the four hints are missing or non-boolean.

For every tool, set all four hints (readOnlyHint, destructiveHint, idempotentHint, openWorldHint) to explicit true/false values that match the handler’s actual behaviour.

Tool inputs are validated

Only 3/28 tool handlers declare input schemas (11%)

Declare an inputSchema with zod/joi/yup on every tool definition.

Tool handlers catch errors

Only 10/28 tool handlers wrap calls in try/catch (36%)

Wrap each tool handler body in try/catch and return a structured error response.

Tests exist

No test files found

Add tests that exercise each declared tool.

Shell command execution

9 child_process calls — runs shell commands

Prefer library functions over shell-outs. If you must shell out, ensure all inputs are properly escaped.

Secrets stay with their owner

1 secret/sensitive value flow into network calls (MCP_AUTH_KEY → dynamic)

Audit where credentials are sent. A NOTION_TOKEN should only reach api.notion.com — never a third-party host.

Secrets not logged

2 secret values sent to console.log

Redact or omit secret values from log output.

Dev dependencies

2 critical/high in dev-only deps (does not ship to users)

Upgrade dev dependencies when convenient.

Dependency freshness

1/23 production deps stale: partial-json@2024-05-14 (2.2y)