obsidian-mcp

Tool annotations

No tools have read-only/destructive annotations

Add readOnlyHint or destructiveHint annotations to every tool so hosts can warn users before invoking.

All four hints declared on every tool

14/14 tools missing one or more hints — add_questions (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); list_questions (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint); delete_question (missing: readOnlyHint, destructiveHint, idempotentHint, openWorldHint), +11 more. OpenAI's directory rejects tools where any of the four hints are missing or non-boolean.

For every tool, set all four hints (readOnlyHint, destructiveHint, idempotentHint, openWorldHint) to explicit true/false values that match the handler’s actual behaviour.

Descriptions match behaviour

1 tool describes read intent but its handler mutates — get_vault_stats (line 310: execSync("git rev-parse --short HEAD", { cwd: vaultRoot, stdio: ["pipe", "pipe", "pipe"] }))

Rename the tool, rewrite the description, or move the side-effect into a separate clearly-named tool.

Tool inputs are validated

13/14 tool handlers declare input schemas (93%)

Declare an inputSchema with zod/joi/yup on every tool definition.

Tool handlers catch errors

Only 2/14 tool handlers wrap calls in try/catch (14%)

Wrap each tool handler body in try/catch and return a structured error response.

License file

No license file

Add a LICENSE file (MIT, Apache-2.0, etc.).

Tests exist

No test files found

Add tests that exercise each declared tool.

Secrets not logged

1 secret value sent to console.log

Redact or omit secret values from log output.

Production dependencies are patched

0 critical, 4 high severity in production deps — @modelcontextprotocol/sdk@1.12.1 (high), @modelcontextprotocol/sdk@1.12.1 (high)

Run npm audit fix, or upgrade the affected packages to a non-vulnerable version.

Dependency freshness

1/10 production deps stale: gray-matter@2023-07-12 (3.1y)

Tool description accuracy

get_vault_stats: description implies read-only but handler writes/deletes/executes

Update tool descriptions to accurately reflect all capabilities — especially write, delete, or execute operations.